Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)
Patch Set: Make //content responsible for generating notification Ids Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 4db7e3ac4b13e923483dd1e665d1324e40b6e776..86026ad6d87b2d8e0a9b2c879612b804bde06f72 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -835,26 +835,24 @@ void ServiceWorkerContextClient::OnFetchEvent(
void ServiceWorkerContextClient::OnNotificationClickEvent(
int request_id,
- int64_t persistent_notification_id,
+ const std::string& notification_id,
const PlatformNotificationData& notification_data,
int action_index) {
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerContextClient::OnNotificationClickEvent");
proxy_->dispatchNotificationClickEvent(
- request_id,
- persistent_notification_id,
- ToWebNotificationData(notification_data),
- action_index);
+ request_id, blink::WebString::fromUTF8(notification_id),
+ ToWebNotificationData(notification_data), action_index);
}
void ServiceWorkerContextClient::OnNotificationCloseEvent(
int request_id,
- int64_t persistent_notification_id,
+ const std::string& notification_id,
const PlatformNotificationData& notification_data) {
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerContextClient::OnNotificationCloseEvent");
proxy_->dispatchNotificationCloseEvent(
- request_id, persistent_notification_id,
+ request_id, blink::WebString::fromUTF8(notification_id),
ToWebNotificationData(notification_data));
}

Powered by Google App Engine
This is Rietveld 408576698