Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: content/browser/notifications/notification_database_data.proto

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)
Patch Set: Make //content responsible for generating notification Ids Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/notifications/notification_database_data.proto
diff --git a/content/browser/notifications/notification_database_data.proto b/content/browser/notifications/notification_database_data.proto
index a3190338c966f3d112d581b6b1343b38844ec78d..3cdb8b6aed318d1d73e49f38099d04010a3659f1 100644
--- a/content/browser/notifications/notification_database_data.proto
+++ b/content/browser/notifications/notification_database_data.proto
@@ -11,9 +11,9 @@ package content;
// Stores information about a Web Notification. This message is the protocol
// buffer meant to serialize the content::NotificationDatabaseData structure.
//
-// Next tag: 5
+// Next tag: 6
message NotificationDatabaseDataProto {
- optional int64 notification_id = 1;
johnme 2016/09/08 15:21:50 Keep a comment documenting what tag #1 was used fo
Peter Beverloo 2016/09/08 18:56:02 Done.
+ optional string notification_id = 5;
johnme 2016/09/08 15:21:50 If this database does in fact get blown away by Ch
Peter Beverloo 2016/09/08 18:56:02 Yes.
optional string origin = 2;
optional int64 service_worker_registration_id = 3;

Powered by Google App Engine
This is Rietveld 408576698