Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7864)

Unified Diff: chrome/browser/notifications/persistent_notification_delegate.h

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)
Patch Set: Make //content responsible for generating notification Ids Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/persistent_notification_delegate.h
diff --git a/chrome/browser/notifications/persistent_notification_delegate.h b/chrome/browser/notifications/persistent_notification_delegate.h
index 375c1d1cca37f1cd9cae1891fb8d11c5bc44b827..3fc29a02b7ef9b22fccfe63c37aae17432e12e6a 100644
--- a/chrome/browser/notifications/persistent_notification_delegate.h
+++ b/chrome/browser/notifications/persistent_notification_delegate.h
@@ -5,7 +5,6 @@
#ifndef CHROME_BROWSER_NOTIFICATIONS_PERSISTENT_NOTIFICATION_DELEGATE_H_
#define CHROME_BROWSER_NOTIFICATIONS_PERSISTENT_NOTIFICATION_DELEGATE_H_
-#include <stdint.h>
#include <string>
#include "base/macros.h"
@@ -22,16 +21,10 @@ class BrowserContext;
class PersistentNotificationDelegate : public NotificationDelegate {
public:
PersistentNotificationDelegate(content::BrowserContext* browser_context,
- int64_t persistent_notification_id,
+ const std::string& notification_id,
const GURL& origin,
int notification_settings_index);
- // Persistent id of this notification in the notification database. To be
- // used when retrieving all information associated with it.
- int64_t persistent_notification_id() const {
- return persistent_notification_id_;
- }
-
// NotificationDelegate implementation.
void Display() override;
void Close(bool by_user) override;
@@ -47,9 +40,8 @@ class PersistentNotificationDelegate : public NotificationDelegate {
private:
content::BrowserContext* browser_context_;
- int64_t persistent_notification_id_;
+ std::string notification_id_;
GURL origin_;
- std::string id_;
int notification_settings_index_;
DISALLOW_COPY_AND_ASSIGN(PersistentNotificationDelegate);

Powered by Google App Engine
This is Rietveld 408576698