chrome/browser/notifications/notification_platform_bridge_android.cc - Issue 2300093002: Make //content responsible for generating notification Ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_platform_bridge_android.cc

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)

Patch Set: Make //content responsible for generating notification Ids Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_platform_bridge_android.h ('k') | chrome/browser/notifications/notification_platform_bridge_mac.h » ('j') | chrome/browser/notifications/persistent_notification_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_platform_bridge_android.cc

diff --git a/chrome/browser/notifications/notification_platform_bridge_android.cc b/chrome/browser/notifications/notification_platform_bridge_android.cc

index a7d4b148c9a7d1969481d11455aad9f3d3f750db..9c3075a749de185d950fd5247926f2325a76eb44 100644

--- a/chrome/browser/notifications/notification_platform_bridge_android.cc

+++ b/chrome/browser/notifications/notification_platform_bridge_android.cc

@@ -12,7 +12,6 @@

#include "base/command_line.h"

#include "base/files/file_path.h"

#include "base/logging.h"

-#include "base/strings/string_number_conversions.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/notifications/native_notification_display_service.h"

#include "chrome/browser/notifications/notification.h"

@@ -284,10 +283,6 @@ bool NotificationPlatformBridgeAndroid::GetDisplayed(

return false;

}

-bool NotificationPlatformBridgeAndroid::SupportsNotificationCenter() const {

- return true;

// static

bool NotificationPlatformBridgeAndroid::RegisterNotificationPlatformBridge(

JNIEnv* env) {