Make //content responsible for generating notification Ids

content/public/browser/platform_notification_context.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_PLATFORM_NOTIFICATION_CONTEXT_H_
 #define CONTENT_PUBLIC_BROWSER_PLATFORM_NOTIFICATION_CONTEXT_H_
 
 #include <stdint.h>
 #include <vector>
 
@@ skipping 16 matching lines @@
   using ReadResultCallback =
       base::Callback<void(bool /* success */,
                           const NotificationDatabaseData&)>;
 
   using ReadAllResultCallback =
       base::Callback<void(bool /* success */,
                           const std::vector<NotificationDatabaseData>&)>;
 
   using WriteResultCallback =
       base::Callback<void(bool /* success */,
-                          int64_t /* notification_id */)>;
+                          const std::string& /* notification_id */)>;
 
   using DeleteResultCallback = base::Callback<void(bool /* success */)>;
 
   // Reads the data associated with |notification_id| belonging to |origin|
   // from the database. |callback| will be invoked with the success status
   // and a reference to the notification database data when completed.
-  virtual void ReadNotificationData(int64_t notification_id,
+  virtual void ReadNotificationData(const std::string& notification_id,
                                     const GURL& origin,
                                     const ReadResultCallback& callback) = 0;
 
   // Reads all data associated with |service_worker_registration_id| belonging
   // to |origin| from the database. |callback| will be invoked with the success
   // status and a vector with all read notification data when completed.
   virtual void ReadAllNotificationDataForServiceWorkerRegistration(
       const GURL& origin,
       int64_t service_worker_registration_id,
       const ReadAllResultCallback& callback) = 0;
 
   // Writes the data associated with a notification to a database. When this

[johnme, 2016/09/08 15:21:50]

Add "The |notification_id| field of |database_data| will be overwritten with a
newly generated ID.".

And perhaps also add a "database_data.notification_id will be generated for us"
comment to the callers for good measure, as this is rather subtle?

[Peter Beverloo, 2016/09/08 18:56:02]

Done.

   // action completed, |callback| will be invoked with the success status and
   // the persistent notification id when written successfully.

[johnme, 2016/09/08 15:21:50]

s/persistent //

[Peter Beverloo, 2016/09/08 18:56:03]

Done.

   virtual void WriteNotificationData(
       const GURL& origin,
       const NotificationDatabaseData& database_data,
       const WriteResultCallback& callback) = 0;
 
   // Deletes all data associated with |notification_id| belonging to |origin|
   // from the database. |callback| will be invoked with the success status
   // when the operation has completed.
-  virtual void DeleteNotificationData(int64_t notification_id,
+  virtual void DeleteNotificationData(const std::string& notification_id,
                                       const GURL& origin,
                                       const DeleteResultCallback& callback) = 0;
 
  protected:
   friend class base::DeleteHelper<PlatformNotificationContext>;
   friend struct BrowserThread::DeleteOnThread<BrowserThread::UI>;
 
   virtual ~PlatformNotificationContext() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_PLATFORM_NOTIFICATION_CONTEXT_H_