Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 2300083002: Wrap MediaMetadata in base::Optional in content and chrome (Closed)
Patch Set: fix Android build Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index e2c42d0eefd9afc07bb09af1a0415f35dff06e6e..da8cc9ea3a987a0474b49faa193e80eebd6e5a5b 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -8,12 +8,12 @@
#include <stdint.h>
#include "base/macros.h"
+#include "base/optional.h"
#include "base/process/kill.h"
#include "base/process/process_handle.h"
#include "content/common/content_export.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/common/frame_navigate_params.h"
-#include "content/public/common/media_metadata.h"
#include "content/public/common/resource_type.h"
#include "content/public/common/security_style.h"
#include "ipc/ipc_listener.h"
@@ -37,6 +37,7 @@ struct AXLocationChangeNotificationDetails;
struct FaviconURL;
struct FrameNavigateParams;
struct LoadCommittedDetails;
+struct MediaMetadata;
struct Referrer;
struct ResourceRedirectDetails;
struct ResourceRequestDetails;
@@ -469,9 +470,10 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
virtual void MediaStoppedPlaying(const MediaPlayerId& id) {}
// Invoked when media session has changed its state.
- virtual void MediaSessionStateChanged(bool is_controllable,
- bool is_suspended,
- const MediaMetadata& metadata) {}
+ virtual void MediaSessionStateChanged(
+ bool is_controllable,
+ bool is_suspended,
+ const base::Optional<MediaMetadata>& metadata) {}
// Invoked when the renderer process changes the page scale factor.
virtual void OnPageScaleFactorChanged(float page_scale_factor) {}
« no previous file with comments | « content/common/media/media_session_messages_android.h ('k') | content/renderer/media/android/renderer_media_session_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698