Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Unified Diff: content/browser/media/session/media_session.h

Issue 2300083002: Wrap MediaMetadata in base::Optional in content and chrome (Closed)
Patch Set: fix Android build Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/media_session.h
diff --git a/content/browser/media/session/media_session.h b/content/browser/media/session/media_session.h
index 9d501fcfd8b7324f41eaf052962620b96e4c43fb..1cb78315bc5f4bd4e9a05600e55c6c9a5f085094 100644
--- a/content/browser/media/session/media_session.h
+++ b/content/browser/media/session/media_session.h
@@ -10,6 +10,7 @@
#include "base/callback_list.h"
#include "base/id_map.h"
#include "base/macros.h"
+#include "base/optional.h"
#include "content/browser/media/session/audio_focus_manager.h"
#include "content/browser/media/session/media_session_uma_helper.h"
#include "content/common/content_export.h"
@@ -63,8 +64,8 @@ class MediaSession : public WebContentsObserver,
~MediaSession() override;
- void SetMetadata(const MediaMetadata& metadata);
- const MediaMetadata& metadata() const { return metadata_; }
+ void SetMetadata(const base::Optional<MediaMetadata>& metadata);
+ const base::Optional<MediaMetadata>& metadata() const { return metadata_; }
// Adds the given player to the current media session. Returns whether the
// player was successfully added. If it returns false, AddPlayer() should be
@@ -218,7 +219,7 @@ class MediaSession : public WebContentsObserver,
// StopDucking().
bool is_ducking_;
- MediaMetadata metadata_;
+ base::Optional<MediaMetadata> metadata_;
base::CallbackList<void(State)> media_session_state_listeners_;
DISALLOW_COPY_AND_ASSIGN(MediaSession);

Powered by Google App Engine
This is Rietveld 408576698