Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: content/renderer/media/android/webmediasession_android.cc

Issue 2300083002: Wrap MediaMetadata in base::Optional in content and chrome (Closed)
Patch Set: addressed Mounir's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/android/webmediasession_android.cc
diff --git a/content/renderer/media/android/webmediasession_android.cc b/content/renderer/media/android/webmediasession_android.cc
index 3601d7f416f9989a511cd0b6a219ecde53917f37..4f957b7700b05ea56a3c3267ea7a98f1bac9c953 100644
--- a/content/renderer/media/android/webmediasession_android.cc
+++ b/content/renderer/media/android/webmediasession_android.cc
@@ -8,6 +8,7 @@
#include "base/logging.h"
#include "base/memory/ptr_util.h"
+#include "base/optional.h"
#include "content/public/common/media_metadata.h"
#include "content/renderer/media/android/renderer_media_session_manager.h"
#include "third_party/WebKit/public/platform/WebIconSizesParser.h"
@@ -39,11 +40,12 @@ void WebMediaSessionAndroid::deactivate(
void WebMediaSessionAndroid::setMetadata(
const blink::WebMediaMetadata* web_metadata) {
- MediaMetadata metadata;
+ base::Optional<MediaMetadata> metadata;
if (web_metadata) {
- metadata.title = web_metadata->title;
- metadata.artist = web_metadata->artist;
- metadata.album = web_metadata->album;
+ metadata = MediaMetadata();
+ metadata->title = web_metadata->title;
+ metadata->artist = web_metadata->artist;
+ metadata->album = web_metadata->album;
for (const auto& web_artwork : web_metadata->artwork) {
MediaMetadata::Artwork artwork;
artwork.src = GURL(base::string16(web_artwork.src));
@@ -53,7 +55,7 @@ void WebMediaSessionAndroid::setMetadata(
artwork.sizes.insert(artwork.sizes.end(),
web_sizes.begin(),
web_sizes.end());
- metadata.artwork.push_back(artwork);
+ metadata->artwork.push_back(artwork);
}
}

Powered by Google App Engine
This is Rietveld 408576698