Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: content/renderer/media/android/renderer_media_session_manager.h

Issue 2300083002: Wrap MediaMetadata in base::Optional in content and chrome (Closed)
Patch Set: addressed Mounir's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/android/renderer_media_session_manager.h
diff --git a/content/renderer/media/android/renderer_media_session_manager.h b/content/renderer/media/android/renderer_media_session_manager.h
index fbfd5c848b057fd027094c836f0634c8748acfca..9f0bd7ab7168ddece1e54fed451ad05864035a3d 100644
--- a/content/renderer/media/android/renderer_media_session_manager.h
+++ b/content/renderer/media/android/renderer_media_session_manager.h
@@ -14,6 +14,10 @@
#include "content/public/renderer/render_frame_observer.h"
#include "third_party/WebKit/public/platform/modules/mediasession/WebMediaSession.h"
+namespace base {
+template <typename T> class Optional;
dcheng 2016/09/06 21:11:16 Let's just #include base/optional.h. One day this
Zhiqiang Zhang (Slow) 2016/09/07 10:45:06 Done.
+} // namespace base
+
namespace content {
class WebMediaSessionAndroid;
@@ -36,7 +40,8 @@ class CONTENT_EXPORT RendererMediaSessionManager : public RenderFrameObserver {
void Deactivate(
int session_id,
std::unique_ptr<blink::WebMediaSessionDeactivateCallback> callback);
- void SetMetadata(int session_id, const MediaMetadata& metadata);
+ void SetMetadata(
+ int session_id, const base::Optional<MediaMetadata>& metadata);
void OnDidActivate(int request_id, bool success);
void OnDidDeactivate(int request_id);

Powered by Google App Engine
This is Rietveld 408576698