Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Side by Side Diff: content/renderer/media/android/webmediasession_android.cc

Issue 2300083002: Wrap MediaMetadata in base::Optional in content and chrome (Closed)
Patch Set: fix Android build Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/media/android/renderer_media_session_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/android/webmediasession_android.h" 5 #include "content/renderer/media/android/webmediasession_android.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "base/optional.h"
11 #include "content/public/common/media_metadata.h" 12 #include "content/public/common/media_metadata.h"
12 #include "content/renderer/media/android/renderer_media_session_manager.h" 13 #include "content/renderer/media/android/renderer_media_session_manager.h"
13 #include "third_party/WebKit/public/platform/WebIconSizesParser.h" 14 #include "third_party/WebKit/public/platform/WebIconSizesParser.h"
14 #include "third_party/WebKit/public/platform/WebSize.h" 15 #include "third_party/WebKit/public/platform/WebSize.h"
15 #include "third_party/WebKit/public/platform/modules/mediasession/WebMediaMetada ta.h" 16 #include "third_party/WebKit/public/platform/modules/mediasession/WebMediaMetada ta.h"
16 17
17 namespace content { 18 namespace content {
18 19
19 WebMediaSessionAndroid::WebMediaSessionAndroid( 20 WebMediaSessionAndroid::WebMediaSessionAndroid(
20 RendererMediaSessionManager* session_manager) 21 RendererMediaSessionManager* session_manager)
(...skipping 11 matching lines...) Expand all
32 session_manager_->Activate(media_session_id_, base::WrapUnique(callback)); 33 session_manager_->Activate(media_session_id_, base::WrapUnique(callback));
33 } 34 }
34 35
35 void WebMediaSessionAndroid::deactivate( 36 void WebMediaSessionAndroid::deactivate(
36 blink::WebMediaSessionDeactivateCallback* callback) { 37 blink::WebMediaSessionDeactivateCallback* callback) {
37 session_manager_->Deactivate(media_session_id_, base::WrapUnique(callback)); 38 session_manager_->Deactivate(media_session_id_, base::WrapUnique(callback));
38 } 39 }
39 40
40 void WebMediaSessionAndroid::setMetadata( 41 void WebMediaSessionAndroid::setMetadata(
41 const blink::WebMediaMetadata* web_metadata) { 42 const blink::WebMediaMetadata* web_metadata) {
42 MediaMetadata metadata; 43 base::Optional<MediaMetadata> metadata;
43 if (web_metadata) { 44 if (web_metadata) {
44 metadata.title = web_metadata->title; 45 metadata = MediaMetadata();
45 metadata.artist = web_metadata->artist; 46 metadata->title = web_metadata->title;
46 metadata.album = web_metadata->album; 47 metadata->artist = web_metadata->artist;
48 metadata->album = web_metadata->album;
47 for (const auto& web_artwork : web_metadata->artwork) { 49 for (const auto& web_artwork : web_metadata->artwork) {
48 MediaMetadata::Artwork artwork; 50 MediaMetadata::Artwork artwork;
49 artwork.src = GURL(base::string16(web_artwork.src)); 51 artwork.src = GURL(base::string16(web_artwork.src));
50 artwork.type = web_artwork.type; 52 artwork.type = web_artwork.type;
51 blink::WebVector<blink::WebSize> web_sizes = 53 blink::WebVector<blink::WebSize> web_sizes =
52 blink::WebIconSizesParser::parseIconSizes(web_artwork.sizes); 54 blink::WebIconSizesParser::parseIconSizes(web_artwork.sizes);
53 artwork.sizes.insert(artwork.sizes.end(), 55 artwork.sizes.insert(artwork.sizes.end(),
54 web_sizes.begin(), 56 web_sizes.begin(),
55 web_sizes.end()); 57 web_sizes.end());
56 metadata.artwork.push_back(artwork); 58 metadata->artwork.push_back(artwork);
57 } 59 }
58 } 60 }
59 61
60 session_manager_->SetMetadata(media_session_id_, metadata); 62 session_manager_->SetMetadata(media_session_id_, metadata);
61 } 63 }
62 64
63 } // namespace content 65 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/media/android/renderer_media_session_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698