Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: content/renderer/media/android/renderer_media_session_manager.h

Issue 2300083002: Wrap MediaMetadata in base::Optional in content and chrome (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_RENDERER_MEDIA_SESSION_MANAGER_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_RENDERER_MEDIA_SESSION_MANAGER_H_
6 #define CONTENT_RENDERER_MEDIA_ANDROID_RENDERER_MEDIA_SESSION_MANAGER_H_ 6 #define CONTENT_RENDERER_MEDIA_ANDROID_RENDERER_MEDIA_SESSION_MANAGER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 10
11 #include "base/id_map.h" 11 #include "base/id_map.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/optional.h"
mlamouri (slow - plz ping) 2016/09/01 17:47:49 ditto
Zhiqiang Zhang (Slow) 2016/09/02 12:11:41 Done.
13 #include "content/common/content_export.h" 14 #include "content/common/content_export.h"
14 #include "content/public/renderer/render_frame_observer.h" 15 #include "content/public/renderer/render_frame_observer.h"
15 #include "third_party/WebKit/public/platform/modules/mediasession/WebMediaSessio n.h" 16 #include "third_party/WebKit/public/platform/modules/mediasession/WebMediaSessio n.h"
16 17
17 namespace content { 18 namespace content {
18 19
19 class WebMediaSessionAndroid; 20 class WebMediaSessionAndroid;
20 struct MediaMetadata; 21 struct MediaMetadata;
21 22
22 class CONTENT_EXPORT RendererMediaSessionManager : public RenderFrameObserver { 23 class CONTENT_EXPORT RendererMediaSessionManager : public RenderFrameObserver {
23 public: 24 public:
24 RendererMediaSessionManager(RenderFrame* render_frame); 25 RendererMediaSessionManager(RenderFrame* render_frame);
25 ~RendererMediaSessionManager() override; 26 ~RendererMediaSessionManager() override;
26 27
27 // RenderFrameObserver override. 28 // RenderFrameObserver override.
28 bool OnMessageReceived(const IPC::Message& msg) override; 29 bool OnMessageReceived(const IPC::Message& msg) override;
29 30
30 int RegisterMediaSession(WebMediaSessionAndroid* session); 31 int RegisterMediaSession(WebMediaSessionAndroid* session);
31 void UnregisterMediaSession(int session_id); 32 void UnregisterMediaSession(int session_id);
32 33
33 void Activate( 34 void Activate(
34 int session_id, 35 int session_id,
35 std::unique_ptr<blink::WebMediaSessionActivateCallback> callback); 36 std::unique_ptr<blink::WebMediaSessionActivateCallback> callback);
36 void Deactivate( 37 void Deactivate(
37 int session_id, 38 int session_id,
38 std::unique_ptr<blink::WebMediaSessionDeactivateCallback> callback); 39 std::unique_ptr<blink::WebMediaSessionDeactivateCallback> callback);
39 void SetMetadata(int session_id, const MediaMetadata& metadata); 40 void SetMetadata(
41 int session_id, const base::Optional<MediaMetadata>& metadata);
40 42
41 void OnDidActivate(int request_id, bool success); 43 void OnDidActivate(int request_id, bool success);
42 void OnDidDeactivate(int request_id); 44 void OnDidDeactivate(int request_id);
43 45
44 private: 46 private:
45 friend class WebMediaSessionTest; 47 friend class WebMediaSessionTest;
46 48
47 // RenderFrameObserver implementation. 49 // RenderFrameObserver implementation.
48 void OnDestruct() override; 50 void OnDestruct() override;
49 51
50 std::map<int, WebMediaSessionAndroid*> sessions_; 52 std::map<int, WebMediaSessionAndroid*> sessions_;
51 int next_session_id_; 53 int next_session_id_;
52 54
53 using ActivationRequests = 55 using ActivationRequests =
54 IDMap<blink::WebMediaSessionActivateCallback, IDMapOwnPointer>; 56 IDMap<blink::WebMediaSessionActivateCallback, IDMapOwnPointer>;
55 ActivationRequests pending_activation_requests_; 57 ActivationRequests pending_activation_requests_;
56 58
57 using DeactivationRequests = 59 using DeactivationRequests =
58 IDMap<blink::WebMediaSessionDeactivateCallback, IDMapOwnPointer>; 60 IDMap<blink::WebMediaSessionDeactivateCallback, IDMapOwnPointer>;
59 DeactivationRequests pending_deactivation_requests_; 61 DeactivationRequests pending_deactivation_requests_;
60 62
61 DISALLOW_COPY_AND_ASSIGN(RendererMediaSessionManager); 63 DISALLOW_COPY_AND_ASSIGN(RendererMediaSessionManager);
62 }; 64 };
63 65
64 } // namespace content 66 } // namespace content
65 67
66 #endif // CONTENT_RENDERER_MEDIA_ANDROID_RENDERER_MEDIA_SESSION_MANAGER_H_ 68 #endif // CONTENT_RENDERER_MEDIA_ANDROID_RENDERER_MEDIA_SESSION_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698