Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2300073003: DevTools: Fix pretty print inconsistent spacing (Closed)

Created:
4 years, 3 months ago by ahmetemirercin
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix pretty print inconsistent spacing BUG=642414 Committed: https://crrev.com/20536ec459a5d475faf25b67566a8728528b0d3b Cr-Commit-Position: refs/heads/master@{#416142}

Patch Set 1 #

Patch Set 2 : Test added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-7.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-7-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/es_tree/AcornTokenizer.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ahmetemirercin
Fixes spaces after null. I think no Layout test required.If so I will write it. ...
4 years, 3 months ago (2016-09-01 21:37:30 UTC) #3
lushnikov
Thank you, let's add a test. Just add one more test here: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-7.html?q=pretty-print-java&sq=package:chromium&l=1
4 years, 3 months ago (2016-09-01 21:46:10 UTC) #4
ahmetemirercin
4 years, 3 months ago (2016-09-01 22:32:49 UTC) #5
lushnikov
lgtm
4 years, 3 months ago (2016-09-01 22:53:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300073003/20001
4 years, 3 months ago (2016-09-01 22:53:38 UTC) #8
ahmetemirercin
On 2016/09/01 22:53:04, lushnikov wrote: > lgtm Thanks.
4 years, 3 months ago (2016-09-01 22:54:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 00:27:06 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 00:29:22 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/20536ec459a5d475faf25b67566a8728528b0d3b
Cr-Commit-Position: refs/heads/master@{#416142}

Powered by Google App Engine
This is Rietveld 408576698