Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 230003002: Add bookmark undo manager commands to the ios grit whitelist. (Closed)

Created:
6 years, 8 months ago by erikchen
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add bookmark undo manager commands to the ios grit whitelist. This is in preparation for bringing the bookmark undo manager to ios. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262802

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +12 lines, -0 lines 2 comments Download

Messages

Total messages: 12 (0 generated)
erikchen
Please review.
6 years, 8 months ago (2014-04-09 01:20:09 UTC) #1
noyau (Ping after 24h)
lgtm https://codereview.chromium.org/230003002/diff/1/build/ios/grit_whitelist.txt File build/ios/grit_whitelist.txt (right): https://codereview.chromium.org/230003002/diff/1/build/ios/grit_whitelist.txt#newcode137 build/ios/grit_whitelist.txt:137: IDS_BOOKMARK_BAR_REDO_REORDER Reorder?
6 years, 8 months ago (2014-04-09 07:44:31 UTC) #2
erikchen
https://codereview.chromium.org/230003002/diff/1/build/ios/grit_whitelist.txt File build/ios/grit_whitelist.txt (right): https://codereview.chromium.org/230003002/diff/1/build/ios/grit_whitelist.txt#newcode137 build/ios/grit_whitelist.txt:137: IDS_BOOKMARK_BAR_REDO_REORDER On 2014/04/09 07:44:31, noyau wrote: > Reorder? These ...
6 years, 8 months ago (2014-04-09 17:35:57 UTC) #3
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 8 months ago (2014-04-09 17:36:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/230003002/1
6 years, 8 months ago (2014-04-09 17:37:16 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 17:37:17 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-09 17:37:17 UTC) #7
erikchen
yfriedman: Looking for an LGTM from a full committer.
6 years, 8 months ago (2014-04-09 17:39:30 UTC) #8
Yaron
On 2014/04/09 17:39:30, erikchen1 wrote: > yfriedman: Looking for an LGTM from a full committer. ...
6 years, 8 months ago (2014-04-09 18:05:35 UTC) #9
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 8 months ago (2014-04-09 18:07:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/230003002/1
6 years, 8 months ago (2014-04-09 18:07:25 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 20:41:57 UTC) #12
Message was sent while issue was closed.
Change committed as 262802

Powered by Google App Engine
This is Rietveld 408576698