Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2300023002: minor SkSL changes to avoid compiler errors in Chromium (Closed)

Created:
4 years, 3 months ago by ethannicholas
Modified:
4 years, 3 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

minor SkSL changes to avoid compiler errors in Chromium * fixed a couple of spots where using { } instead of an explicit constructor call resulted in errors * Type::Field had a deleted copy constructor and therefore was not working inside std::vector; had to remove const from fields and change fType from a reference to a pointer GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300023002 Committed: https://skia.googlesource.com/skia/+/0730be7c303ac415484b15ef44ff1dce077a93b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M src/sksl/SkSLGLSLCodeGenerator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/sksl/SkSLIRGenerator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/sksl/SkSLParser.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/sksl/SkSLSPIRVCodeGenerator.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/sksl/ir/SkSLFieldAccess.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sksl/ir/SkSLSymbolTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/sksl/ir/SkSLType.h View 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ethannicholas
4 years, 3 months ago (2016-09-01 14:28:25 UTC) #4
dogben
lgtm
4 years, 3 months ago (2016-09-01 14:39:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300023002/1
4 years, 3 months ago (2016-09-01 14:43:30 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 14:59:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0730be7c303ac415484b15ef44ff1dce077a93b8

Powered by Google App Engine
This is Rietveld 408576698