Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2300003003: Force SkPath::getConvexity() cache for thread safety. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Force SkPath::getConvexity() cache for thread safety. I happened to stumble on this in a run of TSAN: https://luci-milo.appspot.com/swarming/task/30fffe9497dc6310/steps/dm/0/stdout BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300003003 Committed: https://skia.googlesource.com/skia/+/d0634eeb565d706df2e148a33f137c6edf42bf2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/core/SkLiteDL.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M src/core/SkRecords.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
mtklein_C
4 years, 3 months ago (2016-09-01 20:18:54 UTC) #5
reed1
lgtm
4 years, 3 months ago (2016-09-01 20:28:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300003003/1
4 years, 3 months ago (2016-09-01 20:33:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d0634eeb565d706df2e148a33f137c6edf42bf2e
4 years, 3 months ago (2016-09-01 20:49:21 UTC) #11
bsalomon
On 2016/09/01 20:49:21, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 3 months ago (2016-09-02 13:02:14 UTC) #12
mtklein
On 2016/09/02 13:02:14, bsalomon wrote: > On 2016/09/01 20:49:21, commit-bot: I haz the power wrote: ...
4 years, 3 months ago (2016-09-02 13:51:37 UTC) #13
mtklein
4 years, 3 months ago (2016-09-02 13:51:48 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2303303002/ by mtklein@google.com.

The reason for reverting is: I don't see anything else in the roll that could
have caused the diff..

Powered by Google App Engine
This is Rietveld 408576698