Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 23000006: Add --host argument to replay.py to allow non-loopback interfaces (Closed)

Created:
7 years, 4 months ago by szym
Modified:
7 years, 4 months ago
Reviewers:
slamm_google, tonyg
CC:
web-page-replay-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/web-page-replay.git@master
Visibility:
Public.

Description

Add --host argument to replay.py to allow non-loopback interfaces This is necessary to support RNDIS-based forwarding from Android. BUG=https://code.google.com/p/chromium/issues/detail?id=272381

Patch Set 1 #

Patch Set 2 : also override http_proxy_address #

Total comments: 2

Patch Set 3 : validate --host #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M replay.py View 1 2 7 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
szym
7 years, 4 months ago (2013-08-14 19:22:42 UTC) #1
tonyg
lgtm Let me know when you are ready and I'll land the patch for you. ...
7 years, 4 months ago (2013-08-15 01:45:37 UTC) #2
szym
https://codereview.chromium.org/23000006/diff/3001/replay.py File replay.py (right): https://codereview.chromium.org/23000006/diff/3001/replay.py#newcode477 replay.py:477: harness_group.add_option('--host', default=None, On 2013/08/15 01:45:37, tonyg wrote: > Should ...
7 years, 4 months ago (2013-08-15 19:01:13 UTC) #3
tonyg
> I could just reject anything that excepts in socket.inet_aton SGTM
7 years, 4 months ago (2013-08-15 19:12:51 UTC) #4
szym
On 2013/08/15 19:12:51, tonyg wrote: > > I could just reject anything that excepts in ...
7 years, 4 months ago (2013-08-15 20:45:54 UTC) #5
tonyg
7 years, 4 months ago (2013-08-15 20:49:59 UTC) #6
On 2013/08/15 20:45:54, szym wrote:
> On 2013/08/15 19:12:51, tonyg wrote:
> > > I could just reject anything that excepts in socket.inet_aton
> > 
> > SGTM
> 
> Done. This is ready to land.

Committed revision 519.

Powered by Google App Engine
This is Rietveld 408576698