Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2299993005: Prepare some BlueButtons in chrome browser ui for switch to Harmony. (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare some BlueButtons in chrome browser ui for switch to Harmony. Relevant to the linked bug as BlueButtons are STYLE_BUTTON LabelButtons. BUG=642920 Committed: https://crrev.com/9de559d6273578ee0faf616cb62ca101ff00c57b Cr-Commit-Position: refs/heads/master@{#416147}

Patch Set 1 #

Patch Set 2 : restore include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/screen_capture_notification_ui_views.cc View 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Evan Stade
4 years, 3 months ago (2016-09-01 23:00:32 UTC) #3
sky
LGTM
4 years, 3 months ago (2016-09-01 23:40:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299993005/20001
4 years, 3 months ago (2016-09-02 00:03:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 00:53:00 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 00:54:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9de559d6273578ee0faf616cb62ca101ff00c57b
Cr-Commit-Position: refs/heads/master@{#416147}

Powered by Google App Engine
This is Rietveld 408576698