Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2299973004: Remove obsolete refs to gyp-[mac|win]-tool (Closed)

Created:
4 years, 3 months ago by scottmg
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M scripts/slave/build_directory.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
scottmg
4 years, 3 months ago (2016-09-01 19:51:02 UTC) #1
scottmg
+dpranke for owners
4 years, 3 months ago (2016-09-01 19:51:43 UTC) #4
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-01 19:55:06 UTC) #7
brettw
lgtm
4 years, 3 months ago (2016-09-01 19:57:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299973004/1
4 years, 3 months ago (2016-09-01 19:58:16 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/8b48b789b84eef6a433f3c8367f0dadbb04a5f00
4 years, 3 months ago (2016-09-01 20:03:21 UTC) #13
scottmg
4 years, 3 months ago (2016-09-06 17:31:05 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2314163002/ by scottmg@chromium.org.

The reason for reverting is: http://crbug.com/643577 official.desktop.builder.

Powered by Google App Engine
This is Rietveld 408576698