Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2299973003: libyuv: refactor recipes (Closed)

Created:
4 years, 3 months ago by kjellander_chromium
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

libyuv: refactor recipes Break out all builder configs into a separate file. Add bot_type to each bot config, in prepration for tester-only builders coming up in a follow-up CL. BUG=643144 Committed: https://chromium.googlesource.com/chromium/tools/build/+/fd84bceb95ee0faa25983d71d8692e8917e2e04d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed some mistakes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -955 lines) Patch
M scripts/slave/recipe_modules/libyuv/api.py View 1 chunk +45 lines, -0 lines 0 comments Download
A + scripts/slave/recipe_modules/libyuv/builders.py View 1 84 chunks +86 lines, -94 lines 0 comments Download
A + scripts/slave/recipe_modules/libyuv/test_api.py View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.py View 1 3 chunks +17 lines, -859 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
kjellander_chromium
Doing this separate to avoid a super-large CL coming up. https://codereview.chromium.org/2299973003/diff/1/scripts/slave/recipe_modules/libyuv/api.py File scripts/slave/recipe_modules/libyuv/api.py (right): https://codereview.chromium.org/2299973003/diff/1/scripts/slave/recipe_modules/libyuv/api.py#newcode18 ...
4 years, 3 months ago (2016-09-01 11:52:21 UTC) #5
ehmaldonado_chromium
On 2016/09/01 11:52:21, kjellander_chromium wrote: > Doing this separate to avoid a super-large CL coming ...
4 years, 3 months ago (2016-09-02 07:37:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299973003/20001
4 years, 3 months ago (2016-09-02 07:51:00 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 07:55:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/fd84bceb95ee0faa2598...

Powered by Google App Engine
This is Rietveld 408576698