Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2299973002: Remove unused VariableLocation::GLOBAL. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused VariableLocation::GLOBAL. Committed: https://crrev.com/281e4d0e3400b45fd3fa12b26b3b06f4019a08ea Cr-Commit-Position: refs/heads/master@{#39078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -55 lines) Patch
M src/ast/prettyprinter.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 6 chunks +0 lines, -6 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 5 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-01 11:42:14 UTC) #6
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-01 11:47:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299973002/1
4 years, 3 months ago (2016-09-01 11:47:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 11:50:02 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 11:50:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/281e4d0e3400b45fd3fa12b26b3b06f4019a08ea
Cr-Commit-Position: refs/heads/master@{#39078}

Powered by Google App Engine
This is Rietveld 408576698