Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2443)

Unified Diff: pdf/out_of_process_instance.cc

Issue 2299943002: Record the PDF and top level URL when the PDF plugin crashes. (Closed)
Patch Set: Remove logging Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pdf/out_of_process_instance.cc
diff --git a/pdf/out_of_process_instance.cc b/pdf/out_of_process_instance.cc
index 42eceb1fc66189d42e9f11e874dffebe699ba169..17beaa8a8d97bd1a4d9e77ca15b4860cbf592854 100644
--- a/pdf/out_of_process_instance.cc
+++ b/pdf/out_of_process_instance.cc
@@ -343,6 +343,7 @@ bool OutOfProcessInstance::Init(uint32_t argc,
const char* stream_url = nullptr;
const char* original_url = nullptr;
+ const char* top_level_url = nullptr;
const char* headers = nullptr;
for (uint32_t i = 0; i < argc; ++i) {
bool success = true;
@@ -350,6 +351,8 @@ bool OutOfProcessInstance::Init(uint32_t argc,
original_url = argv[i];
else if (strcmp(argn[i], "stream-url") == 0)
stream_url = argv[i];
+ else if (!full_ && strcmp(argn[i], "top-level-url") == 0)
raymes 2016/09/07 06:10:14 I'd be ok to set this even if full_ is true. What
Lei Zhang 2016/09/08 01:10:31 Sure. Not a big deal either way.
+ top_level_url = argv[i];
else if (strcmp(argn[i], "headers") == 0)
headers = argv[i];
else if (strcmp(argn[i], "background-color") == 0)
@@ -376,6 +379,7 @@ bool OutOfProcessInstance::Init(uint32_t argc,
LoadUrl(stream_url);
url_ = original_url;
+ pp::PDF::SetCrashData(GetPluginInstance(), original_url, top_level_url);
return engine_->New(original_url, headers);
}

Powered by Google App Engine
This is Rietveld 408576698