chrome/browser/extensions/api/streams_private/streams_private_api.cc - Issue 2299943002: Record the PDF and top level URL when the PDF plugin crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/streams_private/streams_private_api.cc

Issue 2299943002: Record the PDF and top level URL when the PDF plugin crashes. (Closed)

Patch Set: Remove logging Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/streams_private/streams_private_api.cc

diff --git a/chrome/browser/extensions/api/streams_private/streams_private_api.cc b/chrome/browser/extensions/api/streams_private/streams_private_api.cc

index 7b8b6b7c5684532fa7c07f7eb64b97526afb8b55..f17bef988217e9e38db5633d59e8b97a46a62c23 100644

--- a/chrome/browser/extensions/api/streams_private/streams_private_api.cc

+++ b/chrome/browser/extensions/api/streams_private/streams_private_api.cc

@@ -85,7 +85,7 @@ void StreamsPrivateAPI::ExecuteMimeTypeHandler(

if (handler->HasPlugin()) {

GURL handler_url(Extension::GetBaseURLFromExtensionId(extension_id).spec() +

handler->handler_url());

- auto tab_id = ExtensionTabUtil::GetTabId(web_contents);

+ int tab_id = ExtensionTabUtil::GetTabId(web_contents);

std::unique_ptr<StreamContainer> stream_container(new StreamContainer(

std::move(stream), tab_id, embedded, handler_url, extension_id));

MimeHandlerStreamManager::Get(browser_context_)

« no previous file with comments | « no previous file | chrome/browser/resources/pdf/browser_api.js » ('j') | chrome/browser/resources/pdf/browser_api.js » ('J')