chrome/browser/resources/pdf/pdf.js - Issue 2299943002: Record the PDF and top level URL when the PDF plugin crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/pdf.js

Issue 2299943002: Record the PDF and top level URL when the PDF plugin crashes. (Closed)

Patch Set: fix typo Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/pdf/pdf.js

diff --git a/chrome/browser/resources/pdf/pdf.js b/chrome/browser/resources/pdf/pdf.js

index 29923a17544e6555ed36f72edf1cd0ef7a410cf4..2c802e687f637ce4b239f5572ef5dbb4b119b68d 100644

--- a/chrome/browser/resources/pdf/pdf.js

+++ b/chrome/browser/resources/pdf/pdf.js

@@ -172,8 +172,12 @@ function PDFViewer(browserApi) {

this.plugin_.setAttribute('background-color', backgroundColor);

this.plugin_.setAttribute('top-toolbar-height', topToolbarHeight);

- if (!this.browserApi_.getStreamInfo().embedded)

+ if (this.browserApi_.getStreamInfo().embedded) {

+ this.plugin_.setAttribute('top-level-url',

+ this.browserApi_.getStreamInfo().tabUrl);

+ } else {

this.plugin_.setAttribute('full-frame', '');

+ }

document.body.appendChild(this.plugin_);

// Setup the button event listeners.

« no previous file with comments | « chrome/browser/resources/pdf/browser_api.js ('k') | pdf/out_of_process_instance.cc » ('j') | no next file with comments »