Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 22999052: Add V8_ALIGNAS() and V8_ALIGNOF() and use that in lazy-instance.h. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add V8_ALIGNAS() and V8_ALIGNOF() and use that in lazy-instance.h. This renames the existing V8_ALIGNAS() to V8_ALIGNED(), and introduces V8_ALIGNAS(type, alignment) which aligns according to the type and falls back to aligning according to alignment. Also use __attribute__((aligned(n))) instead of __attribute__((__aligned__(n))). R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -24 lines) Patch
M include/v8config.h View 7 chunks +60 lines, -10 lines 0 comments Download
M src/circular-queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/lazy-instance.h View 3 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Reland with better handling for older GCCs and MSVC.
7 years, 3 months ago (2013-08-26 09:35:59 UTC) #1
Sven Panne
lgtm
7 years, 3 months ago (2013-08-26 10:38:18 UTC) #2
Benedikt Meurer
7 years, 3 months ago (2013-08-26 11:18:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16318 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698