Issue 22999033: Add Platform.packageRoot and Platform.executableArguments to dart:io.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22999033: Add Platform.packageRoot and Platform.executableArguments to dart:io. (Closed)

Created:
7 years, 4 months ago by Bill Hesse

Modified:
7 years, 4 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Add Platform.packageRoot and Platform.executableArguments to dart:io. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=26432

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -3 lines)			Patch
M	runtime/bin/io_natives.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/main.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/bin/platform.h	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	runtime/bin/platform.cc	View		2 chunks	+28 lines, -0 lines	0 comments	Download
M	runtime/bin/platform_patch.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/lib/io_patch.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	sdk/lib/io/platform.dart	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	sdk/lib/io/platform_impl.dart	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	tests/standalone/io/platform_test.dart	View		3 chunks	+17 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Bill Hesse

I would like to change executableArguments to executableFlags everywhere, since it is only the flags, ...

7 years, 4 months ago (2013-08-21 13:04:08 UTC) #1

Søren Gjesse

LGTM I think we should stick the the "argument" name. This is what we call ...

7 years, 4 months ago (2013-08-21 14:10:24 UTC) #2

Bill Hesse

7 years, 4 months ago (2013-08-21 15:22:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r26432 (presubmit successful).