Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2299903002: [turbofan] Only check semantic axis for Type::None. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Only check semantic axis for Type::None. R=jarin@chromium.org BUG=chromium:643073 Committed: https://crrev.com/432790c92c8541624a2c0c4fc762764840d172ff Cr-Commit-Position: refs/heads/master@{#39065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M src/compiler/representation-change.cc View 8 chunks +8 lines, -8 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-643073.js View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-01 06:48:52 UTC) #1
Jarin
lgtm
4 years, 3 months ago (2016-09-01 06:50:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299903002/1
4 years, 3 months ago (2016-09-01 06:57:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 07:11:15 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 07:11:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/432790c92c8541624a2c0c4fc762764840d172ff
Cr-Commit-Position: refs/heads/master@{#39065}

Powered by Google App Engine
This is Rietveld 408576698