Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 22999007: Linux brk() syscall returns the new program break (Closed)

Created:
7 years, 4 months ago by Petr Hosek
Modified:
7 years, 4 months ago
CC:
chromium-reviews, Markus (顧孟勤)
Visibility:
Public.

Description

Linux brk() syscall returns the new program break The behavior of the Linux brk() system call is different from the behavior provided by the glibc wrapper. The actual system call returns the new program break on success. On failure, the system call returns the current break. This change fixes the LSS brk() declaration to match the Linux system call rather than that of the glibc wrapper. BUG= none TEST= none R=mseaborn@chromium.org Committed: https://code.google.com/p/linux-syscall-support/source/detail?r=22

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M linux_syscall_support.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Petr Hosek
7 years, 4 months ago (2013-08-14 17:48:01 UTC) #1
Mark Seaborn
Please rerun "git cl upload": https://codereview.chromium.org/22999007/diff/1/linux_syscall_support.h says "error: old chunk mismatch".
7 years, 4 months ago (2013-08-14 18:10:01 UTC) #2
Petr Hosek
On 2013/08/14 18:10:01, Mark Seaborn wrote: > Please rerun "git cl upload": > https://codereview.chromium.org/22999007/diff/1/linux_syscall_support.h says ...
7 years, 4 months ago (2013-08-14 18:12:56 UTC) #3
Mark Seaborn
LGTM. Please set "BUG=none" and "TEST=none": don't just leave these fields empty. What is the ...
7 years, 4 months ago (2013-08-14 18:17:54 UTC) #4
Petr Hosek
On 2013/08/14 18:17:54, Mark Seaborn wrote: > LGTM. Please set "BUG=none" and "TEST=none": don't just ...
7 years, 4 months ago (2013-08-14 18:39:25 UTC) #5
Petr Hosek
7 years, 4 months ago (2013-08-16 17:31:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698