Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2299893003: Converted Observatory logging-page element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Updated observatory_sources.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -265 lines) Patch
M runtime/observatory/lib/elements.dart View 1 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/event.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 1 4 chunks +17 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 1 chunk +21 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 chunk +48 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/logging.dart View 1 chunk +112 lines, -181 lines 0 comments Download
D runtime/observatory/lib/src/elements/logging.html View 1 chunk +0 lines, -72 lines 0 comments Download
A runtime/observatory/lib/src/elements/logging_list.dart View 1 chunk +84 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/event.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/event.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/repositories/event.dart View 4 chunks +4 lines, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/event.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
cbernaschina
4 years, 3 months ago (2016-09-01 23:03:29 UTC) #2
rmacnak
lgtm
4 years, 3 months ago (2016-09-02 16:57:25 UTC) #3
cbernaschina
4 years, 3 months ago (2016-09-02 17:25:53 UTC) #4
cbernaschina
4 years, 3 months ago (2016-09-02 17:27:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2eab4de3157913cf0a10c9f8f82d9071069b4493 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698