Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2299893002: ChromeOS: Enable Material Design OOBE by default. (Closed)

Created:
4 years, 3 months ago by Alexander Alekseev
Modified:
4 years, 3 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS: Enable Material Design OOBE by default. This CL turns on polymer-based OOBE by default. BUG=604119 TEST=none Committed: https://crrev.com/bc099185878fda1c06351f745e19aff4fe6fac64 Cr-Commit-Position: refs/heads/master@{#416169}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update after review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Alexander Alekseev
Please review.
4 years, 3 months ago (2016-09-01 06:29:08 UTC) #2
achuithb
lgtm https://codereview.chromium.org/2299893002/diff/1/chromeos/chromeos_switches.cc File chromeos/chromeos_switches.cc (right): https://codereview.chromium.org/2299893002/diff/1/chromeos/chromeos_switches.cc#newcode249 chromeos/chromeos_switches.cc:249: // Enables material design OOBE UI. Fix comment
4 years, 3 months ago (2016-09-01 18:16:54 UTC) #7
Alexander Alekseev
https://codereview.chromium.org/2299893002/diff/1/chromeos/chromeos_switches.cc File chromeos/chromeos_switches.cc (right): https://codereview.chromium.org/2299893002/diff/1/chromeos/chromeos_switches.cc#newcode249 chromeos/chromeos_switches.cc:249: // Enables material design OOBE UI. On 2016/09/01 18:16:54, ...
4 years, 3 months ago (2016-09-01 21:35:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299893002/20001
4 years, 3 months ago (2016-09-02 01:14:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 02:28:17 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 02:29:34 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bc099185878fda1c06351f745e19aff4fe6fac64
Cr-Commit-Position: refs/heads/master@{#416169}

Powered by Google App Engine
This is Rietveld 408576698