android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java - Issue 2299883007: Remove video overlay support from WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java

Issue 2299883007: Remove video overlay support from WebView (Closed)

Patch Set: Removed another external_video_surface reference Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/jni_dependency_factory.h ('k') | android_webview/java/src/org/chromium/android_webview/AwSettings.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java

diff --git a/android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java b/android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java

index 95d316fc1e2b38dbf4016cf6a5098461836e9e3f..ec63750ead346fe61e94fdb7254b6f1327f0dad6 100644

--- a/android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java

+++ b/android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java

@@ -553,11 +553,12 @@ public class ContentSettingsAdapter extends android.webkit.WebSettings {

@Override

public void setVideoOverlayForEmbeddedEncryptedVideoEnabled(boolean flag) {

- mAwSettings.setVideoOverlayForEmbeddedVideoEnabled(flag);

+ // No-op, see http://crbug.com/616583

}

@Override

public boolean getVideoOverlayForEmbeddedEncryptedVideoEnabled() {

- return mAwSettings.getVideoOverlayForEmbeddedVideoEnabled();

+ // Always false, see http://crbug.com/616583

+ return false;

}