Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2399)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwSettings.java

Issue 2299883007: Remove video overlay support from WebView (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwSettings.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwSettings.java b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
index ea93c487e7361672424d75e3a878d6b2ebc4c5c2..bbdc755065cbc411bd4856d136c64f6c2e39d911 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwSettings.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
@@ -88,7 +88,6 @@ public class AwSettings {
private boolean mEnableSupportedHardwareAcceleratedFeatures = false;
private int mMixedContentMode = WebSettings.MIXED_CONTENT_NEVER_ALLOW;
- private boolean mForceVideoOverlayForTests = false;
private boolean mOffscreenPreRaster = false;
private int mDisabledMenuItems = MENU_ITEM_NONE;
@@ -1713,29 +1712,6 @@ public class AwSettings {
return false;
}
- @CalledByNative
- private boolean getVideoOverlayForEmbeddedVideoEnabledLocked() {
- // Always false, see http://crbug.com/616583
- return false;
- }
-
- @VisibleForTesting
- public void setForceVideoOverlayForTests(final boolean enabled) {
- synchronized (mAwSettingsLock) {
- if (mForceVideoOverlayForTests != enabled) {
- mForceVideoOverlayForTests = enabled;
- mEventHandler.runOnUiThreadBlockingAndLocked(new Runnable() {
- @Override
- public void run() {
- if (mNativeAwSettings != 0) {
- nativeUpdateRendererPreferencesLocked(mNativeAwSettings);
- }
- }
- });
- }
- }
- }
-
@VisibleForTesting
public void updateAcceptLanguages() {
synchronized (mAwSettingsLock) {
@@ -1751,12 +1727,6 @@ public class AwSettings {
}
@CalledByNative
- private boolean getForceVideoOverlayForTests() {
- assert Thread.holdsLock(mAwSettingsLock);
- return mForceVideoOverlayForTests;
- }
-
- @CalledByNative
private boolean supportsDoubleTapZoomLocked() {
assert Thread.holdsLock(mAwSettingsLock);
return mSupportZoom && mBuiltInZoomControls && mUseWideViewport;

Powered by Google App Engine
This is Rietveld 408576698