Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1929)

Unified Diff: appengine/findit/handlers/crash/crash_handler.py

Issue 2299883005: [Findit] Add findit_for_client to do analysis based on client_id (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/type_enums.py ('k') | appengine/findit/handlers/crash/test/crash_handler_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/crash/crash_handler.py
diff --git a/appengine/findit/handlers/crash/crash_handler.py b/appengine/findit/handlers/crash/crash_handler.py
index b43c41e33a80f58b7a68c48d460eae8da7641ec8..64970dda5c61d4bed496a3a2d34ae932bf661836 100644
--- a/appengine/findit/handlers/crash/crash_handler.py
+++ b/appengine/findit/handlers/crash/crash_handler.py
@@ -59,6 +59,37 @@ class CrashHandler(BaseHandler):
'channel': 'beta',
'signature': '[ThreadWatcher UI hang] base::MessagePumpBase::Run'
}
+
+ customized_data, client_id and crash_identifiers vary from client to client.
+ For example, for fracas,
+
+ customized_data: {
+ "trend_type": "d", # *see supported types below
+ "channel": "beta",
+ "historical_metadata": [
+ {
+ "report_number": 0,
+ "cpm": 0.0,
+ "client_number": 0,
+ "chrome_version": "51.0.2704.103"
+ },
+ ...
+ {
+ "report_number": 10,
+ "cpm": 2.1,
+ "client_number": 8,
+ "chrome_version": "53.0.2768.0"
+ },
+ ]
+ }
+
+ crash_identifiers: {
+ "platform": "mac",
+ "version": "52.0.2743.41",
+ "process_type": "browser",
+ "channel": "beta",
+ "signature": "[ThreadWatcher UI hang] base::MessagePumpCFRunLoopBase::Run"
+ }
"""
try:
received_message = json.loads(self.request.body)
@@ -78,9 +109,8 @@ class CrashHandler(BaseHandler):
crash_data['client_id'],
crash_data['platform'],
crash_data['stack_trace'],
- crash_data['customized_data']['channel'],
- crash_data['customized_data']['historical_metadata'],
- queue_name=constants.CRASH_ANALYSIS_FRACAS_QUEUE)
+ crash_data['customized_data'],
+ queue_name=constants.CRASH_ANALYSIS_QUEUE[crash_data['client_id']])
except (KeyError, ValueError): # pragma: no cover.
# TODO: save exception in datastore and create a page to show them.
logging.exception('Failed to process crash message')
« no previous file with comments | « appengine/findit/crash/type_enums.py ('k') | appengine/findit/handlers/crash/test/crash_handler_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698