Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: src/compiler/typer.cc

Issue 2299883003: [turbofan] Float32Constant/Float64Constant cannot occur in JS level graph. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/simplified-lowering.cc ('k') | test/cctest/compiler/test-js-constant-cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/typer.cc
diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index 89a74ada893c744e2b46adacc5a7e886905d0a76..4f97772c8be20a0cb5b1553823d2abf749bab3f3 100644
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -580,14 +580,14 @@ Type* Typer::Visitor::TypeRelocatableInt64Constant(Node* node) {
}
Type* Typer::Visitor::TypeFloat32Constant(Node* node) {
- return Type::Intersect(Type::Of(OpParameter<float>(node), zone()),
- Type::UntaggedFloat32(), zone());
+ UNREACHABLE();
+ return nullptr;
}
Type* Typer::Visitor::TypeFloat64Constant(Node* node) {
- return Type::Intersect(Type::Of(OpParameter<double>(node), zone()),
- Type::UntaggedFloat64(), zone());
+ UNREACHABLE();
+ return nullptr;
}
« no previous file with comments | « src/compiler/simplified-lowering.cc ('k') | test/cctest/compiler/test-js-constant-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698