[wasm] consolidate wasm and asm.js module compilation sequence

[wasm] consolidate wasm and asm.js module compilation sequence

This unblocks avoiding the separate code template.
In the upcoming CL doing away with code templates, We need to track instances
through the module object, which needs to be separate from the compiled module
data, which is then shared with the first instance.

This CL ensures we have the object available in the asm.js scenario, too.

Note that this CL also unifies the error messaging when module
decoding fails.

BUG=v8:5316
Committed: https://crrev.com/5f8a6ec4b13a054033bd42f8998f2fbb2e7da9c7
Cr-Commit-Position: refs/heads/master@{#39097}

[Mircea Trofin, 2016-09-01 03:28:11]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 03:28:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2016-09-01 03:31:18]

Description was changed from

==========
[wasm] consolidate wasm and asm.js module compilation sequence

This unblocks avoiding the separate code template.
In the upcoming CL doing away with code templates, We need to track instances
through the module object, which needs to be separate from the compiled module
data, which is then shared with the first instance.

This CL ensures we have the object available in the asm.js scenario, too.


BUG=
==========

to

==========
[wasm] consolidate wasm and asm.js module compilation sequence

This unblocks avoiding the separate code template.
In the upcoming CL doing away with code templates, We need to track instances
through the module object, which needs to be separate from the compiled module
data, which is then shared with the first instance.

This CL ensures we have the object available in the asm.js scenario, too.

Note that this CL also unifies the error messaging when module 
decoding fails. 

BUG=v8:5316
==========

[Mircea Trofin, 2016-09-01 03:31:18]

mtrofin@chromium.org changed reviewers:
+ bradnelson@chromium.org

[commit-bot: I haz the power, 2016-09-01 03:48:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 03:48:11]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/13459)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[bradnelson, 2016-09-01 03:48:31]

https://codereview.chromium.org/2299873002/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (left):

https://codereview.chromium.org/2299873002/diff/1/src/wasm/wasm-js.cc#oldcode353
src/wasm/wasm-js.cc:353: if (!FLAG_expose_wasm) {
I don't think you want to drop this.
This will make the Wasm object visible all the time!

https://codereview.chromium.org/2299873002/diff/1/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/2299873002/diff/1/src/wasm/wasm-module.h#newc...
src/wasm/wasm-module.h:406: bool verify, ModuleOrigin origin);
None of the callers use the verify option being true, why have it?

[Mircea Trofin, 2016-09-01 04:34:38]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 04:34:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2016-09-01 04:35:10]

Patchset #2 (id:20001) has been deleted

[Mircea Trofin, 2016-09-01 04:36:18]

https://codereview.chromium.org/2299873002/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (left):

https://codereview.chromium.org/2299873002/diff/1/src/wasm/wasm-js.cc#oldcode353
src/wasm/wasm-js.cc:353: if (!FLAG_expose_wasm) {
On 2016/09/01 03:48:31, bradnelson wrote:
> I don't think you want to drop this.
> This will make the Wasm object visible all the time!

Done.

https://codereview.chromium.org/2299873002/diff/1/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/2299873002/diff/1/src/wasm/wasm-module.h#newc...
src/wasm/wasm-module.h:406: bool verify, ModuleOrigin origin);
On 2016/09/01 03:48:31, bradnelson wrote:
> None of the callers use the verify option being true, why have it?

Done.

[commit-bot: I haz the power, 2016-09-01 05:06:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 05:06:14]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng_trigg...)

[Mircea Trofin, 2016-09-01 05:14:18]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 05:14:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 05:25:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 05:25:34]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng_trigg...)

[Mircea Trofin, 2016-09-01 05:27:39]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 05:27:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 05:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 05:49:13]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2016-09-01 15:54:42]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-09-01 15:54:42]

lgtm

[commit-bot: I haz the power, 2016-09-01 15:54:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 16:47:22]

Description was changed from

==========
[wasm] consolidate wasm and asm.js module compilation sequence

This unblocks avoiding the separate code template.
In the upcoming CL doing away with code templates, We need to track instances
through the module object, which needs to be separate from the compiled module
data, which is then shared with the first instance.

This CL ensures we have the object available in the asm.js scenario, too.

Note that this CL also unifies the error messaging when module 
decoding fails. 

BUG=v8:5316
==========

to

==========
[wasm] consolidate wasm and asm.js module compilation sequence

This unblocks avoiding the separate code template.
In the upcoming CL doing away with code templates, We need to track instances
through the module object, which needs to be separate from the compiled module
data, which is then shared with the first instance.

This CL ensures we have the object available in the asm.js scenario, too.

Note that this CL also unifies the error messaging when module 
decoding fails. 

BUG=v8:5316
==========

[commit-bot: I haz the power, 2016-09-01 16:47:24]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-01 16:47:50]

Description was changed from

==========
[wasm] consolidate wasm and asm.js module compilation sequence

This unblocks avoiding the separate code template.
In the upcoming CL doing away with code templates, We need to track instances
through the module object, which needs to be separate from the compiled module
data, which is then shared with the first instance.

This CL ensures we have the object available in the asm.js scenario, too.

Note that this CL also unifies the error messaging when module 
decoding fails. 

BUG=v8:5316
==========

to

==========
[wasm] consolidate wasm and asm.js module compilation sequence

This unblocks avoiding the separate code template.
In the upcoming CL doing away with code templates, We need to track instances
through the module object, which needs to be separate from the compiled module
data, which is then shared with the first instance.

This CL ensures we have the object available in the asm.js scenario, too.

Note that this CL also unifies the error messaging when module
decoding fails.

BUG=v8:5316

Committed: https://crrev.com/5f8a6ec4b13a054033bd42f8998f2fbb2e7da9c7
Cr-Commit-Position: refs/heads/master@{#39097}
==========

[commit-bot: I haz the power, 2016-09-01 16:47:51]

Patchset 3 (id:??) landed as
https://crrev.com/5f8a6ec4b13a054033bd42f8998f2fbb2e7da9c7
Cr-Commit-Position: refs/heads/master@{#39097}