Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2299853002: dbus: Rewrite ObjectProxy::CallMethodWithErrorCallback's comment (Closed)

Created:
4 years, 3 months ago by hashimoto
Modified:
4 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

dbus: Rewrite ObjectProxy::CallMethodWithErrorCallback's comment To make it clear which callback can get a nullptr when. BUG=None Committed: https://crrev.com/fd6b5515d45ca8559708fa1479dd762ad7c67225 Cr-Commit-Position: refs/heads/master@{#415890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M dbus/object_proxy.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hashimoto
(cont. from https://codereview.chromium.org/2291453006/#msg24) Please let me know any typos/grammatical errors/ambiguity/whatever you notice. Thanks!
4 years, 3 months ago (2016-09-01 02:30:24 UTC) #2
Daniel Erat
thanks, lgtm! and i see that the method that doesn't take an error callback already ...
4 years, 3 months ago (2016-09-01 04:19:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299853002/1
4 years, 3 months ago (2016-09-01 04:33:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 05:19:00 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 05:20:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd6b5515d45ca8559708fa1479dd762ad7c67225
Cr-Commit-Position: refs/heads/master@{#415890}

Powered by Google App Engine
This is Rietveld 408576698