Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2299803002: Revert of Disabled flaky test AppBackgroundPageApiTest.NoJsBackgroundPage (Closed)

Created:
4 years, 3 months ago by stanisc
Modified:
4 years, 3 months ago
Reviewers:
ncarter (slow), battre
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disabled flaky test AppBackgroundPageApiTest.NoJsBackgroundPage (patchset #1 id:1 of https://codereview.chromium.org/2294113003/ ) Reason for revert: The bug is now fixed so disabling this test is no longer needed. See https://codereview.chromium.org/2293293002/ Original issue's description: > Disabled flaky test AppBackgroundPageApiTest.NoJsBackgroundPage > > BUG=642482 > TBR=stanisc@chromium.org,nick@chromium.org > > Committed: https://crrev.com/940f8f135b20b2e5bca8c76ad036eb98e142def0 > Cr-Commit-Position: refs/heads/master@{#415620} TBR=nick@chromium.org,battre@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642482 Committed: https://crrev.com/c224a65e52b3f824721e1d802faf87f239481823 Cr-Commit-Position: refs/heads/master@{#415749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/extensions/app_background_page_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
stanisc
Created Revert of Disabled flaky test AppBackgroundPageApiTest.NoJsBackgroundPage
4 years, 3 months ago (2016-08-31 20:53:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299803002/1
4 years, 3 months ago (2016-08-31 20:53:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 20:54:42 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 21:00:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c224a65e52b3f824721e1d802faf87f239481823
Cr-Commit-Position: refs/heads/master@{#415749}

Powered by Google App Engine
This is Rietveld 408576698