Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Issue 2299783002: dart2js: Fix some problems with mixins and generics (Closed)

Created:
4 years, 3 months ago by sra1
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Fix some problems with mixins and generics Force the generation of substitutions for mixins at mixin applications. This compensates for the partial lack of rules for mixins in the code that anticipates which substitutions are required. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a7087aa7c425cc374a31d617fa5efb9c521f0618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 5 chunks +13 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
4 years, 3 months ago (2016-09-01 15:37:15 UTC) #4
Siggi Cherem (dart-lang)
lgtm
4 years, 3 months ago (2016-09-01 15:49:59 UTC) #5
sra1
4 years, 3 months ago (2016-09-01 18:08:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
a7087aa7c425cc374a31d617fa5efb9c521f0618 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698