Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2299773002: grid WIP

Created:
4 years, 3 months ago by rwlbuis
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, rwlbuis, jfernandez, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, blink-reviews-css, devtools-reviews_chromium.org, Manuel Rego, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, svillar, apavlov+blink_chromium.org, darktears, blink-reviews, kozyatinskiy+blink_chromium.org, Eric Willigers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make transition/animation shorthands set initial values BUG=386459 patch from issue 2292263002 at patchset 120001 (http://crrev.com/2292263002#ps120001)

Patch Set 1 #

Patch Set 2 : Add border #

Patch Set 3 : Try background #

Patch Set 4 : Background fixes #

Patch Set 5 : More fixes #

Patch Set 6 : Fix all tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+669 lines, -599 lines) Patch
M third_party/WebKit/LayoutTests/animations/animations-csstext.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/animations/animations-parsing.html View 7 chunks +48 lines, -48 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/animations-parsing-expected.txt View 1 chunk +48 lines, -48 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/backgrounds/background-position-parsing-2.html View 1 2 3 4 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/backgrounds/background-position-parsing-2-expected.txt View 1 2 3 4 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html View 1 2 3 4 9 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt View 1 2 3 4 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt View 5 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/background-clip-text-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/background-image-size-serialization.html View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/background-image-size-serialization-expected.txt View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/background-position-serialize-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/background-serialize.html View 1 2 3 4 5 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/parsing-unitless-length-quirk.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/script-tests/background-clip-text.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/shorthand-mismatched-list-crash.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/shorthand-mismatched-list-crash-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/transform-inline-style-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/transform-inline-style-remove-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/background-shorthand-csstext.html View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/background-shorthand-csstext-expected.txt View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/inspector-support/style-expected.txt View 1 2 3 4 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/masking/parsing-mask.html View 1 2 3 4 5 2 chunks +68 lines, -68 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/masking/parsing-mask-expected.txt View 1 2 3 4 5 2 chunks +68 lines, -68 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects-expected.txt View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/cssom-media-insert-crash-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/inject-stylesheet-expected.txt View 1 2 3 4 4 chunks +55 lines, -55 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/lazy-computed-style-expected.txt View 1 2 3 4 3 chunks +27 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-computed-trace-expected.txt View 1 2 3 4 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-keyframes-expected.txt View 4 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-new-API-expected.txt View 1 2 3 4 3 chunks +27 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/transitions/transitions-parsing.html View 2 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/transitions/transitions-parsing-expected.txt View 3 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl View 1 2 3 4 2 chunks +105 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPropertyMetadata.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.h View 1 2 3 4 5 4 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 1 2 3 4 5 5 chunks +4 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 5 6 chunks +14 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp View 7 chunks +2 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
rwlbuis
Description was changed from ========== Make transition/animation shorthands set initial values BUG=386459 patch from issue ...
4 years, 3 months ago (2016-08-31 20:25:58 UTC) #1
rwlbuis
Patchset #3 (id:40001) has been deleted
4 years, 3 months ago (2016-09-01 18:14:04 UTC) #2
rwlbuis
4 years, 3 months ago (2016-09-01 22:33:40 UTC) #3
Patchset #5 (id:100001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698