Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2299763002: Fix compilation error on gcc 4.8.5 on s390x (Closed)

Created:
4 years, 3 months ago by john.yan
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix compilation error on gcc 4.8.5 on s390x This fixes "error: array subscript is below array bounds" error message generated by gcc 4.8.5 R=mvstanton@chromium.org, bmeurer@chromium.org BUG= Committed: https://crrev.com/d8792ab02c05d14d5577e2e5af3a8aff53ec2906 Cr-Commit-Position: refs/heads/master@{#39086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/base/ieee754.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
john.yan
PTAL
4 years, 3 months ago (2016-08-31 19:35:43 UTC) #1
Benedikt Meurer
Thanks, LGTM.
4 years, 3 months ago (2016-09-01 03:45:20 UTC) #6
mvstanton
yes, thanks! LGTM
4 years, 3 months ago (2016-09-01 07:04:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299763002/1
4 years, 3 months ago (2016-09-01 13:28:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 13:30:19 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 13:31:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8792ab02c05d14d5577e2e5af3a8aff53ec2906
Cr-Commit-Position: refs/heads/master@{#39086}

Powered by Google App Engine
This is Rietveld 408576698