Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 229973004: Remove calls to non-handlified version of GetProperty(name). (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Remove calls to non-handlified version of GetProperty(name). R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20611

Patch Set 1 #

Total comments: 6

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -175 lines) Patch
M src/api.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M src/debug.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M src/factory.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M src/isolate.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/messages.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/runtime.cc View 3 chunks +13 lines, -6 lines 0 comments Download
M test/cctest/test-compiler.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M test/cctest/test-heap.cc View 1 16 chunks +48 lines, -51 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 2 chunks +43 lines, -55 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 8 months ago (2014-04-09 08:10:14 UTC) #1
Igor Sheludko
lgtm with nits: https://codereview.chromium.org/229973004/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/229973004/diff/1/src/runtime.cc#newcode9352 src/runtime.cc:9352: isolate, value, MakePair(Failure::Exception(), NULL)); Is it ...
6 years, 8 months ago (2014-04-09 09:52:33 UTC) #2
Yang
https://codereview.chromium.org/229973004/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/229973004/diff/1/src/runtime.cc#newcode9352 src/runtime.cc:9352: isolate, value, MakePair(Failure::Exception(), NULL)); On 2014/04/09 09:52:33, Igor Sheludko ...
6 years, 8 months ago (2014-04-09 10:34:44 UTC) #3
Yang
6 years, 8 months ago (2014-04-09 12:22:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20611 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698