Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2299723002: [chromedriver] Remove invalid assertions from tests. (Closed)

Created:
4 years, 3 months ago by samuong
Modified:
4 years, 3 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Remove invalid assertions from tests. These tests assume that no extension background pages have loaded at the start of the test, but for some reason DevTools is reporting these earlier than it used to. It's valid to have these background pages in the window list, so I've removed the assertions. BUG= TBR=stgao@chromium.org Committed: https://crrev.com/e6877e7e07e21d42dc1fb57184c0ff2851b9e859 Cr-Commit-Position: refs/heads/master@{#415701}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299723002/1
4 years, 3 months ago (2016-08-31 17:50:26 UTC) #2
stgao
lgtm
4 years, 3 months ago (2016-08-31 18:04:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 18:50:20 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e6877e7e07e21d42dc1fb57184c0ff2851b9e859 Cr-Commit-Position: refs/heads/master@{#415701}
4 years, 3 months ago (2016-08-31 18:52:45 UTC) #6
samuong
4 years, 3 months ago (2016-09-01 16:55:32 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2295403003/ by samuong@chromium.org.

The reason for reverting is: reverting in favor of crrev.com/415873, which fixes
the way we handle background pages from devtools.

Powered by Google App Engine
This is Rietveld 408576698