Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2299703005: Rename TestMojoMediaClient -> DefaultMojoMediaClient. (Closed)

Created:
4 years, 3 months ago by alokp
Modified:
4 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, alokp+watch_chromium.org, darin (slow to review), Aaron Boodman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename TestMojoMediaClient -> DefaultMojoMediaClient. BUG=641559 Committed: https://crrev.com/e883daacd91ec1513ab8e0224182667c4aa8960e Cr-Commit-Position: refs/heads/master@{#416042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -159 lines) Patch
M media/media_options.gni View 1 chunk +0 lines, -4 lines 0 comments Download
M media/mojo/services/BUILD.gn View 2 chunks +2 lines, -15 lines 0 comments Download
M media/mojo/services/default_mojo_media_client.h View 2 chunks +19 lines, -0 lines 0 comments Download
M media/mojo/services/default_mojo_media_client.cc View 1 chunk +56 lines, -4 lines 0 comments Download
M media/mojo/services/main.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M media/mojo/services/mojo_media_application_factory.cc View 1 chunk +1 line, -4 lines 0 comments Download
D media/mojo/services/test_mojo_media_client.h View 1 chunk +0 lines, -51 lines 0 comments Download
D media/mojo/services/test_mojo_media_client.cc View 1 chunk +0 lines, -76 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
alokp
4 years, 3 months ago (2016-09-01 04:35:26 UTC) #4
sandersd (OOO until July 31)
lgtm
4 years, 3 months ago (2016-09-01 20:40:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299703005/1
4 years, 3 months ago (2016-09-01 20:41:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 20:47:24 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 20:49:43 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e883daacd91ec1513ab8e0224182667c4aa8960e
Cr-Commit-Position: refs/heads/master@{#416042}

Powered by Google App Engine
This is Rietveld 408576698