Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 2299703003: Re-land: Only allow HTTP/0.9 support on default ports. (Closed)

Created:
2 years, 7 months ago by mmenke
Modified:
2 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, tnagel+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Only allow HTTP/0.9 support on default ports. Also add a group policy to allow HTTP/0.9 support on other ports, which I plan to remove in a couple revisions. Originally landed in https://codereview.chromium.org/2253653002/ Reverted in https://codereview.chromium.org/2297263002/ for breaking WebSocket tests. TBR=eroman@chromium.org BUG=624462, 637017 Committed: https://crrev.com/a7da6da864dce77fe1c931653635c3ac757219cb Cr-Commit-Position: refs/heads/master@{#416074}

Patch Set 1 #

Patch Set 2 : Fix websocket tests #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -47 lines) Patch
M chrome/browser/io_thread.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 5 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/errorpage_browsertest.cc View 3 chunks +45 lines, -0 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +3 lines, -0 lines 0 comments Download
M components/policy/resources/policy_templates.json View 2 chunks +22 lines, -1 line 0 comments Download
M net/http/http_basic_state.h View 3 chunks +8 lines, -1 line 0 comments Download
M net/http/http_basic_state.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M net/http/http_basic_state_unittest.cc View 5 chunks +15 lines, -8 lines 0 comments Download
M net/http/http_basic_stream.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_basic_stream.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 2 chunks +53 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_stream_parser.h View 2 chunks +11 lines, -0 lines 0 comments Download
M net/http/http_stream_parser.cc View 3 chunks +16 lines, -1 line 0 comments Download
M net/http/http_stream_parser_unittest.cc View 1 2 4 chunks +95 lines, -14 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 2 chunks +4 lines, -1 line 0 comments Download
M net/test/embedded_test_server/default_handlers.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M net/websockets/websocket_basic_handshake_stream.cc View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/websocket/handshake-error-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-maxlength-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-prepended-null-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
mmenke
I'll plan to TBR this and land tomorrow (After adjusting for any new policies that ...
2 years, 7 months ago (2016-08-31 19:33:36 UTC) #8
Steven Holte
histograms still lgtm
2 years, 7 months ago (2016-08-31 21:51:09 UTC) #9
Adam Rice
lgtm
2 years, 7 months ago (2016-09-01 03:23:17 UTC) #10
pastarmovj
still lgtm
2 years, 7 months ago (2016-09-01 09:11:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299703003/60001
2 years, 7 months ago (2016-09-01 14:59:34 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:60001)
2 years, 7 months ago (2016-09-01 21:57:12 UTC) #16
commit-bot: I haz the power
2 years, 7 months ago (2016-09-01 21:59:45 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a7da6da864dce77fe1c931653635c3ac757219cb
Cr-Commit-Position: refs/heads/master@{#416074}

Powered by Google App Engine
This is Rietveld 408576698