Fix loading accessibility tree for child frame that's already loaded.

Fix loading accessibility tree for child frame that's already loaded.

Code leftover from the pre-OOPIF days was causing us to exit early from
the RenderAccessibilityImpl constructor for some child frames that were
already loaded. Everything worked fine if accessibility was already enabled
when loading the frame, but if the frame was already loaded and then
accessibility was enabled, this could cause it to fail to create an
accessibility tree.

The code in RenderAccessibilityImpl is no longer needed because now we
have exactly one accessibility tree per frame.

This wasn't caught by tests because we didn't cover both scenarios, we
always enabled accessibility first.

Added two variants of existing tests that load the page first and then
enable accessibility.

BUG=640231
Committed: https://crrev.com/08139c18be3cbc6199636ae63783574dd317bafd
Cr-Commit-Position: refs/heads/master@{#415733}

[dmazzoni, 2016-08-31 16:22:29]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2016-08-31 16:22:49]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[commit-bot: I haz the power, 2016-08-31 16:22:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 17:31:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 17:31:25]

Dry run: This issue passed the CQ dry run.

[David Tseng, 2016-08-31 19:58:22]

lgtm

[dmazzoni, 2016-08-31 20:03:08]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-08-31 20:03:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 20:08:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-31 20:12:43]

Description was changed from

==========
Fix loading accessibility tree for child frame that's already loaded.

Code leftover from the pre-OOPIF days was causing us to exit early from
the RenderAccessibilityImpl constructor for some child frames that were
already loaded. Everything worked fine if accessibility was already enabled
when loading the frame, but if the frame was already loaded and then
accessibility was enabled, this could cause it to fail to create an
accessibility tree.

The code in RenderAccessibilityImpl is no longer needed because now we
have exactly one accessibility tree per frame.

This wasn't caught by tests because we didn't cover both scenarios, we
always enabled accessibility first.

Added two variants of existing tests that load the page first and then
enable accessibility.

BUG=640231
==========

to

==========
Fix loading accessibility tree for child frame that's already loaded.

Code leftover from the pre-OOPIF days was causing us to exit early from
the RenderAccessibilityImpl constructor for some child frames that were
already loaded. Everything worked fine if accessibility was already enabled
when loading the frame, but if the frame was already loaded and then
accessibility was enabled, this could cause it to fail to create an
accessibility tree.

The code in RenderAccessibilityImpl is no longer needed because now we
have exactly one accessibility tree per frame.

This wasn't caught by tests because we didn't cover both scenarios, we
always enabled accessibility first.

Added two variants of existing tests that load the page first and then
enable accessibility.

BUG=640231

Committed: https://crrev.com/08139c18be3cbc6199636ae63783574dd317bafd
Cr-Commit-Position: refs/heads/master@{#415733}
==========

[commit-bot: I haz the power, 2016-08-31 20:12:46]

Patchset 1 (id:??) landed as
https://crrev.com/08139c18be3cbc6199636ae63783574dd317bafd
Cr-Commit-Position: refs/heads/master@{#415733}

[yhirano, 2016-09-01 02:22:42]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2299113002/ by yhirano@chromium.org.

The reason for reverting is: The added tests are failing on Mac.
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/7967.

[yhirano, 2016-09-01 02:31:28]

On 2016/09/01 02:22:42, yhirano wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2299113002/ by mailto:yhirano@chromium.org.
> 
> The reason for reverting is: The added tests are failing on Mac.
>
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/7967.

Not only on Mac but also on Windows.
https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds...