Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2299653002: SkDocument: turn off SK_SUPPORT_LEGACY_DOCUMENT_API (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkDocument: turn off SK_SUPPORT_LEGACY_DOCUMENT_API no one seems to be using it. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2299653002 Committed: https://skia.googlesource.com/skia/+/e86134fc703eba776715a9e0fdcb6c4e6f7d60e7

Patch Set 1 #

Patch Set 2 : delete all LEGACY_DOCUMENT_API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -136 lines) Patch
M include/core/SkDocument.h View 1 3 chunks +0 lines, -91 lines 0 comments Download
M src/pdf/SkPDFDocument.h View 1 1 chunk +1 line, -6 lines 0 comments Download
M src/pdf/SkPDFDocument.cpp View 1 1 chunk +0 lines, -20 lines 0 comments Download
M src/pdf/SkPDFMetadata.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/pdf/SkPDFMetadata.cpp View 1 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
hal.canary
ptal
4 years, 3 months ago (2016-08-31 15:01:53 UTC) #7
hal.canary
deleted everything. take another look.
4 years, 3 months ago (2016-09-06 15:50:50 UTC) #8
reed1
love it -- all red. lgtm
4 years, 3 months ago (2016-09-06 15:58:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299653002/20001
4 years, 3 months ago (2016-09-06 16:01:20 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 16:32:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e86134fc703eba776715a9e0fdcb6c4e6f7d60e7

Powered by Google App Engine
This is Rietveld 408576698