Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2299613004: Converted Observatory timeline-page element (Closed)
Patch Set: Reverted change to service Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/elements.html ('k') | runtime/observatory/lib/src/elements/css/shared.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index 4130dda43cdd542bef0cee64429b9d777f14e691..361ac7adde8702f2d1f83f9a681abaad8252bf2f 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -799,14 +799,11 @@ class TimelinePage extends Page {
TimelinePage(app) : super(app);
void onInstall() {
- if (element == null) {
- element = new Element.tag('timeline-page');
- }
- assert(element != null);
+ element = new TimelinePageElement(app.vm, app.events, app.notifications,
+ queue: app.queue);
}
void _visit(Uri uri) {
- assert(element != null);
assert(canVisit(uri));
}
« no previous file with comments | « runtime/observatory/lib/elements.html ('k') | runtime/observatory/lib/src/elements/css/shared.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698