Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2299613004: Converted Observatory timeline-page element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Converted Observatory timeline-page element Not fully testable R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c38769ea9a327afff8fede185623d773cd343f16

Patch Set 1 #

Patch Set 2 : Added cross-origin access from localhost #

Patch Set 3 : Avoid to detached the iframe during rendering #

Total comments: 1

Patch Set 4 : merged with master #

Patch Set 5 : Reverted change to service #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -189 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 3 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/timeline_page.dart View 1 2 3 chunks +243 lines, -135 lines 0 comments Download
D runtime/observatory/lib/src/elements/timeline_page.html View 1 chunk +0 lines, -46 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
cbernaschina
4 years, 3 months ago (2016-09-01 00:47:24 UTC) #2
rmacnak
Changing the recorder streams through either the dropdown or check boxes now causes me to ...
4 years, 3 months ago (2016-09-01 17:54:23 UTC) #3
cbernaschina
4 years, 3 months ago (2016-09-01 20:22:53 UTC) #4
cbernaschina
4 years, 3 months ago (2016-09-01 20:51:24 UTC) #5
rmacnak
lgtm https://chromiumcodereview.appspot.com/2299613004/diff/40001/runtime/bin/vmservice/server.dart File runtime/bin/vmservice/server.dart (right): https://chromiumcodereview.appspot.com/2299613004/diff/40001/runtime/bin/vmservice/server.dart#newcode99 runtime/bin/vmservice/server.dart:99: final uri = Uri.parse(request.headers['Origin']?.single ?? 'http://localhost'); Let's put ...
4 years, 3 months ago (2016-09-02 16:42:01 UTC) #6
cbernaschina
4 years, 3 months ago (2016-09-02 17:38:13 UTC) #7
cbernaschina
4 years, 3 months ago (2016-09-02 17:38:49 UTC) #9
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
c38769ea9a327afff8fede185623d773cd343f16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698