Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2299603002: MemoryCache: Remove MEMORY_CACHE_STATS (Closed)

Created:
4 years, 3 months ago by hiroshige
Modified:
4 years, 3 months ago
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@WeakMemoryCache_revert
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MemoryCache: Remove MEMORY_CACHE_STATS Now that we have memory-infra, I expect we can remove debug code under MEMORY_CACHE_STATS. This CL removes printf() debug code that cause presubmit warnings (follow-up of a comment in https://codereview.chromium.org/2254593003/). BUG=603791 Committed: https://crrev.com/de40c6d2ae75ce62ee8fbf11066dacedb016e987 Cr-Commit-Position: refs/heads/master@{#416242}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
M third_party/WebKit/Source/core/fetch/MemoryCache.h View 1 3 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 1 2 chunks +0 lines, -51 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
hiroshige
PTAL.
4 years, 3 months ago (2016-09-01 09:03:11 UTC) #2
yhirano
lgtm
4 years, 3 months ago (2016-09-01 10:40:43 UTC) #4
Mike West
lgtm
4 years, 3 months ago (2016-09-02 08:46:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299603002/20001
4 years, 3 months ago (2016-09-02 09:23:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 12:03:11 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 12:05:25 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de40c6d2ae75ce62ee8fbf11066dacedb016e987
Cr-Commit-Position: refs/heads/master@{#416242}

Powered by Google App Engine
This is Rietveld 408576698