Change buttons in WindowTypeLauncher to MdTextButton

Change buttons in WindowTypeLauncher to MdTextButton

This isn't guarded by any flag because it's non-production code. You
can see the WindowTypeLauncher by building and running
ash_shell_with_content.

BUG=642920
Committed: https://crrev.com/05cb506faa6d5da3990acc94b915bdb8a7768478
Cr-Commit-Position: refs/heads/master@{#416107}

[Evan Stade, 2016-08-31 21:59:58]

estade@chromium.org changed reviewers:
+ jamescook@chromium.org

[Evan Stade, 2016-08-31 22:07:21]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 22:08:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-31 22:41:52]

LGTM

https://codereview.chromium.org/2299583003/diff/40001/ash/shell/window_type_l...
File ash/shell/window_type_launcher.cc (right):

https://codereview.chromium.org/2299583003/diff/40001/ash/shell/window_type_l...
ash/shell/window_type_launcher.cc:177: :
create_button_(views::MdTextButton::CreateMdButton(
nit: "using views::MdTextButton;" might make this more readable

https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_typ...
File mash/example/window_type_launcher/window_type_launcher.cc (right):

https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_typ...
mash/example/window_type_launcher/window_type_launcher.cc:233:
create_button_(views::MdTextButton::CreateMdButton(
ditto

[Evan Stade, 2016-08-31 22:45:19]

https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_typ...
File mash/example/window_type_launcher/window_type_launcher.cc (right):

https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_typ...
mash/example/window_type_launcher/window_type_launcher.cc:233:
create_button_(views::MdTextButton::CreateMdButton(
On 2016/08/31 22:41:52, James Cook wrote:
> ditto

do we often use using for views classes? I will admit this ought to be
views::MdTextButton::Create but there are a handful of files to update so I
decided to punt that.

[James Cook, 2016-08-31 22:47:00]

On 2016/08/31 22:45:19, Evan Stade wrote:
>
https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_typ...
> File mash/example/window_type_launcher/window_type_launcher.cc (right):
> 
>
https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_typ...
> mash/example/window_type_launcher/window_type_launcher.cc:233:
> create_button_(views::MdTextButton::CreateMdButton(
> On 2016/08/31 22:41:52, James Cook wrote:
> > ditto
> 
> do we often use using for views classes? I will admit this ought to be
> views::MdTextButton::Create but there are a handful of files to update so I
> decided to punt that.

We sometimes use "using" for views classes. I've often seen it used for
views::Widget and views::View.

[commit-bot: I haz the power, 2016-08-31 23:34:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 23:34:21]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-09-01 00:53:21]

https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_typ...
File mash/example/window_type_launcher/window_type_launcher.cc (right):

https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_typ...
mash/example/window_type_launcher/window_type_launcher.cc:233:
create_button_(views::MdTextButton::CreateMdButton(
On 2016/08/31 22:41:52, James Cook wrote:
> ditto

Done.

[Evan Stade, 2016-09-01 00:53:28]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-09-01 00:53:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2299583003/#ps60001
(title: "using views::MdTextButton")

[commit-bot: I haz the power, 2016-09-01 00:53:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 01:00:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 01:00:07]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2016-09-01 19:59:12]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2016-09-01 19:59:12]

+sky for mash owners

[sky, 2016-09-01 21:48:42]

LGTM

[Evan Stade, 2016-09-01 23:00:08]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-09-01 23:00:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 23:05:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-01 23:08:31]

Description was changed from

==========
Change buttons in WindowTypeLauncher to MdTextButton

This isn't guarded by any flag because it's non-production code. You
can see the WindowTypeLauncher by building and running
ash_shell_with_content.

BUG=642920
==========

to

==========
Change buttons in WindowTypeLauncher to MdTextButton

This isn't guarded by any flag because it's non-production code. You
can see the WindowTypeLauncher by building and running
ash_shell_with_content.

BUG=642920

Committed: https://crrev.com/05cb506faa6d5da3990acc94b915bdb8a7768478
Cr-Commit-Position: refs/heads/master@{#416107}
==========

[commit-bot: I haz the power, 2016-09-01 23:08:32]

Patchset 4 (id:??) landed as
https://crrev.com/05cb506faa6d5da3990acc94b915bdb8a7768478
Cr-Commit-Position: refs/heads/master@{#416107}