Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2299583003: Change buttons in WindowTypeLauncher to MdTextButton (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change buttons in WindowTypeLauncher to MdTextButton This isn't guarded by any flag because it's non-production code. You can see the WindowTypeLauncher by building and running ash_shell_with_content. BUG=642920 Committed: https://crrev.com/05cb506faa6d5da3990acc94b915bdb8a7768478 Cr-Commit-Position: refs/heads/master@{#416107}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : also do mash version #

Total comments: 4

Patch Set 4 : using views::MdTextButton #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -114 lines) Patch
M ash/shell/window_type_launcher.h View 1 2 chunks +13 lines, -14 lines 0 comments Download
M ash/shell/window_type_launcher.cc View 1 2 3 5 chunks +26 lines, -37 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 2 3 5 chunks +50 lines, -63 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Evan Stade
4 years, 3 months ago (2016-08-31 21:59:59 UTC) #2
James Cook
LGTM https://codereview.chromium.org/2299583003/diff/40001/ash/shell/window_type_launcher.cc File ash/shell/window_type_launcher.cc (right): https://codereview.chromium.org/2299583003/diff/40001/ash/shell/window_type_launcher.cc#newcode177 ash/shell/window_type_launcher.cc:177: : create_button_(views::MdTextButton::CreateMdButton( nit: "using views::MdTextButton;" might make this ...
4 years, 3 months ago (2016-08-31 22:41:52 UTC) #5
Evan Stade
https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_type_launcher/window_type_launcher.cc File mash/example/window_type_launcher/window_type_launcher.cc (right): https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_type_launcher/window_type_launcher.cc#newcode233 mash/example/window_type_launcher/window_type_launcher.cc:233: create_button_(views::MdTextButton::CreateMdButton( On 2016/08/31 22:41:52, James Cook wrote: > ditto ...
4 years, 3 months ago (2016-08-31 22:45:19 UTC) #6
James Cook
On 2016/08/31 22:45:19, Evan Stade wrote: > https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_type_launcher/window_type_launcher.cc > File mash/example/window_type_launcher/window_type_launcher.cc (right): > > https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_type_launcher/window_type_launcher.cc#newcode233 ...
4 years, 3 months ago (2016-08-31 22:47:00 UTC) #7
Evan Stade
https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_type_launcher/window_type_launcher.cc File mash/example/window_type_launcher/window_type_launcher.cc (right): https://codereview.chromium.org/2299583003/diff/40001/mash/example/window_type_launcher/window_type_launcher.cc#newcode233 mash/example/window_type_launcher/window_type_launcher.cc:233: create_button_(views::MdTextButton::CreateMdButton( On 2016/08/31 22:41:52, James Cook wrote: > ditto ...
4 years, 3 months ago (2016-09-01 00:53:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299583003/60001
4 years, 3 months ago (2016-09-01 00:53:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/250840)
4 years, 3 months ago (2016-09-01 01:00:07 UTC) #15
Evan Stade
+sky for mash owners
4 years, 3 months ago (2016-09-01 19:59:12 UTC) #17
sky
LGTM
4 years, 3 months ago (2016-09-01 21:48:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299583003/60001
4 years, 3 months ago (2016-09-01 23:00:36 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-01 23:05:12 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 23:08:32 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/05cb506faa6d5da3990acc94b915bdb8a7768478
Cr-Commit-Position: refs/heads/master@{#416107}

Powered by Google App Engine
This is Rietveld 408576698