Add "use-winrt-midi-api" flag to enable WinRT WebMIDI backend

Add "use-winrt-midi-api" flag to enable WinRT WebMIDI backend

The WinRT WebMIDI implementation is currently behind a compile-time flag
(midi_use_winrt). Now we provide both WinMM and WinRT implementations in the
browser and use a runtime flag to switch between them.

BUG=512433
Committed: https://crrev.com/682aa57d696476168651f22017105faa676d8d79
Cr-Commit-Position: refs/heads/master@{#416183}

[Shao-Chuan Lee, 2016-09-01 07:41:15]

Description was changed from

==========
Add "use-winrt-midi-api" flag to enable WinRT WebMIDI backend

The WinRT WebMIDI implementation is currently behind a compile-time flag
(midi_use_winrt). Now we provide both WinMM and WinRT implementations in the
browser and use a runtime flag to switch between them.

BUG=512433
==========

to

==========
Add "use-winrt-midi-api" flag to enable WinRT WebMIDI backend

The WinRT WebMIDI implementation is currently behind a compile-time flag
(midi_use_winrt). Now we provide both WinMM and WinRT implementations in the
browser and use a runtime flag to switch between them.

BUG=512433
==========

[Shao-Chuan Lee, 2016-09-01 07:41:15]

shaochuan@chromium.org changed reviewers:
+ toyoshim@chromium.org

[Shao-Chuan Lee, 2016-09-01 07:43:20]

I'd like to go for a CQ dry run first to check if it works on Windows 7, then
I'll add other reviewers to check the flag. Thanks.

[Takashi Toyoshima, 2016-09-01 07:47:38]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 07:47:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shao-Chuan Lee, 2016-09-01 08:11:02]

The CQ bit was unchecked by shaochuan@chromium.org

[Shao-Chuan Lee, 2016-09-01 09:48:20]

https://codereview.chromium.org/2299543009/diff/1/media/midi/midi_manager_win...
File media/midi/midi_manager_winrt.cc (right):

https://codereview.chromium.org/2299543009/diff/1/media/midi/midi_manager_win...
media/midi/midi_manager_winrt.cc:199: return GetStringFromObjectMethod<T,
&T::get_Id>(obj);
This triggers error C2893 and C2672 in amd64_x86 MSVC but didn't in amd64 MSVC.
Confirmed that same headers are included, is this a compiler bug?
Now expanding the template to workaround this.

https://codereview.chromium.org/2299543009/diff/1/media/midi/midi_manager_win...
media/midi/midi_manager_winrt.cc:204: return GetStringFromObjectMethod<T,
&T::get_DeviceId>(obj);
ditto

https://codereview.chromium.org/2299543009/diff/1/media/midi/midi_manager_win...
media/midi/midi_manager_winrt.cc:209: &IDeviceInformation::get_Name>(info);
ditto

https://codereview.chromium.org/2299543009/diff/20001/media/midi/midi_manager...
File media/midi/midi_manager_winrt.cc (right):

https://codereview.chromium.org/2299543009/diff/20001/media/midi/midi_manager...
media/midi/midi_manager_winrt.cc:8: // https://reviews.llvm.org/D23895
Definition in <robuffer.h> is using

[uuid(...)] struct IBufferByteAccess;

instead of

struct __declspec(uuid("...")) IBufferByteAccess;

and is not recognized by clang.

[Shao-Chuan Lee, 2016-09-01 09:48:38]

The CQ bit was checked by shaochuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 09:48:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 09:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 09:48:54]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Takashi Toyoshima, 2016-09-01 09:50:17]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 09:50:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 10:37:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 10:37:20]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Takashi Toyoshima, 2016-09-01 11:05:35]

toyoshim@chromium.org changed reviewers:
+ isherman@chromium.org

[Takashi Toyoshima, 2016-09-01 11:08:30]

+isherman for histograms.xml change to add a chrome flag

Hi Ilya. Though this change still needs some minor works to make it pass to
compile on some configurations, can you take a look on histograms.xml change?

[Shao-Chuan Lee, 2016-09-01 11:10:28]

The CQ bit was checked by shaochuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 11:10:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 11:10:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 11:10:47]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Ilya Sherman, 2016-09-01 19:15:58]

histograms.xml lgtm

[Shao-Chuan Lee, 2016-09-02 01:13:20]

The CQ bit was checked by shaochuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 01:13:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 02:48:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 02:48:09]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2016-09-02 03:15:16]

lgtm

[Shao-Chuan Lee, 2016-09-02 03:40:29]

The CQ bit was checked by shaochuan@chromium.org

[commit-bot: I haz the power, 2016-09-02 03:40:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 03:45:31]

Description was changed from

==========
Add "use-winrt-midi-api" flag to enable WinRT WebMIDI backend

The WinRT WebMIDI implementation is currently behind a compile-time flag
(midi_use_winrt). Now we provide both WinMM and WinRT implementations in the
browser and use a runtime flag to switch between them.

BUG=512433
==========

to

==========
Add "use-winrt-midi-api" flag to enable WinRT WebMIDI backend

The WinRT WebMIDI implementation is currently behind a compile-time flag
(midi_use_winrt). Now we provide both WinMM and WinRT implementations in the
browser and use a runtime flag to switch between them.

BUG=512433
==========

[commit-bot: I haz the power, 2016-09-02 03:45:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-02 03:50:18]

Description was changed from

==========
Add "use-winrt-midi-api" flag to enable WinRT WebMIDI backend

The WinRT WebMIDI implementation is currently behind a compile-time flag
(midi_use_winrt). Now we provide both WinMM and WinRT implementations in the
browser and use a runtime flag to switch between them.

BUG=512433
==========

to

==========
Add "use-winrt-midi-api" flag to enable WinRT WebMIDI backend

The WinRT WebMIDI implementation is currently behind a compile-time flag
(midi_use_winrt). Now we provide both WinMM and WinRT implementations in the
browser and use a runtime flag to switch between them.

BUG=512433

Committed: https://crrev.com/682aa57d696476168651f22017105faa676d8d79
Cr-Commit-Position: refs/heads/master@{#416183}
==========

[commit-bot: I haz the power, 2016-09-02 03:50:20]

Patchset 2 (id:??) landed as
https://crrev.com/682aa57d696476168651f22017105faa676d8d79
Cr-Commit-Position: refs/heads/master@{#416183}